[ui] Hide jobs with dunder anonymous prefix #23185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @hellendag and the rest of your teammates on |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 18bd9a3. |
salazarm
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
@smackesey is introducing a new anonymous job prefix. We should handle this the same as the existing
__ASSET_JOBprefix, which is to hide it aggressively throughout the app.The simplest thing to do here seems to be to just add it as another check alongside the existing prefix check.
How I Tested These Changes
Run dagster dev with a target code location that includes sensors and schedules with anonymous jobs using the new prefix.
View Jobs list, verify that these jobs don't appear. View Schedules and Sensors lists, verify same.