[ui] Filters for merged automation table #23181
Conversation
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @hellendag and the rest of your teammates on |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 7a0063d. |
| const [automationTypes, setAutomationTypes] = useQueryPersistedState<Set<AutomationType>>({ | ||
| encode: (vals) => ({automationType: vals.size ? Array.from(vals).join(',') : undefined}), | ||
| decode: (qs) => new Set((qs.automationType?.split(',') as AutomationType[]) || []), | ||
| }); |
There was a problem hiding this comment.
I think our users are starting to expect that all filters be encoded in URL state. Can we add the other 2 filters to the URL too?
There was a problem hiding this comment.
It's already in place for instigation state, via useInstigationStatusFilter.
For code locations, I'm just using the existing useCodeLocationFilter, so maybe that's the right place to make that change if we want to make it more widespread after all...
Summary & Motivation
Add filters to the merged Automations page: code location, running state, and automation type (schedule/sensor). Also add text search.
How I Tested These Changes
View
/automations/merged, verify that filters behave as expected.