split up context/compute.py into multiple modules #23171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
branch-name: asset-execution-context
b5cab64
to
2826e3b
Compare
jamiedemaria
approved these changes
Jul 24, 2024
| from contextlib import contextmanager | ||
| from contextvars import ContextVar | ||
| from inspect import _empty as EmptyAnnotation | ||
| from typing import AbstractSet, Any, Dict, Iterator, List, Mapping, Optional, Sequence, Union, cast | ||
| from typing import Iterator, Optional, Union |
There was a problem hiding this comment.
i always found the name of this file confusing - maybe now that its just the context manager maybe it could be like enter_context_helper or something else. not beholden to this though
There was a problem hiding this comment.
The way I had interpreted it was that "compute context" is the more general term that spans OpExecutionContext, AssetExecutionContext, and AssetCheckExecutionContext. I don't feel particularly invested in preserving this, but I do think enter_context_helper would be a little narrow, given that this module also holds ExecutionContextTypes and current_execution_context.
In light of that, going to punt figuring out the right name to a future PR.
sryza
added a commit
that referenced
this pull request
Jul 24, 2024
## Summary & Motivation I sometimes get lost in compute.py and find it hard to tell which context class I'm in. I think this will help. ## How I Tested These Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
I sometimes get lost in compute.py and find it hard to tell which context class I'm in. I think this will help.
How I Tested These Changes