PLA 509 dump docker compose logs on failure #23167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmsanders
reviewed
Jul 23, 2024
python_modules/dagster-test/dagster_test/fixtures/docker_compose.py
Outdated
Show resolved
Hide resolved
021be7a
to
b26effd
Compare
jmsanders
approved these changes
Jul 23, 2024
b26effd
to
2fbfbb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
when docker-compose up throws an exception, just dump docker logs to stdout. sometimes there isn't anything more revealing here than what we get in the initial exception, but sometimes it points to an issue with the underlying service that wasn't in the original exception
How I Tested These Changes
forced docker-compose to fail with a bad health check definition, and ensured that the dump_logs function was invoked and did print to stdout