Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update source_code.py to allow self-hosted GitLab for code references #23160

Conversation

cooperellidge
Copy link
Contributor

Summary & Motivation

Currently the git code reference feature only works for URLs containing "gitlab.com" and "github.com". This doesn't work with self-hosted GitLab because the string "gitlab.com" is not in "gitlab.self-hosted.xyz".

#23135

How I Tested These Changes

Confirmed locally against self-hosted GitLab instance.

@cooperellidge cooperellidge changed the title Update source_code.py Update source_code.py to allow self-hosted GitLab for code references Jul 23, 2024
@garethbrickman garethbrickman linked an issue Jul 23, 2024 that may be closed by this pull request
Copy link
Member

@benpankow benpankow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@benpankow benpankow merged commit 849e65e into dagster-io:master Jul 23, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend code references git_url to include self-hosted GitLab
2 participants