Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make Definitions a record #23119

Merged
merged 2 commits into from
Jul 23, 2024
Merged

make Definitions a record #23119

merged 2 commits into from
Jul 23, 2024
+67 −91

Conversation

sryza
Copy link
Contributor

@sryza sryza commented Jul 19, 2024

Summary & Motivation

This reflects its post-#22909 role as a "dumb" data class.

How I Tested These Changes

@sryza sryza requested a review from dpeng817 July 19, 2024 19:25
Base automatically changed from definitions-no-validate to master July 19, 2024 19:26
@sryza sryza force-pushed the definitions-record branch 3 times, most recently from ceb44fe to 252e163 Compare July 22, 2024 20:24
dpeng817
dpeng817 approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@dpeng817 dpeng817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okie dokie

@sryza sryza merged commit f00450d into master Jul 23, 2024
1 check failed
@sryza sryza deleted the definitions-record branch July 23, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpeng817 dpeng817 dpeng817 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sryza @dpeng817