Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch get_event_records => fetch_materializations for multi asset sensors #22779

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

prha
Copy link
Member

@prha prha commented Jun 28, 2024

Summary & Motivation

The last vestige of framework calls to get_event_records.

How I Tested These Changes

BK

@prha prha requested a review from sryza June 29, 2024 02:00
@prha prha merged commit 49fccf2 into master Jul 9, 2024
1 check passed
@prha prha deleted the prha/get_event_records branch July 9, 2024 23:24
gibsondan added a commit that referenced this pull request Jul 25, 2024
…asset sensors (#22779)"

This reverts commit 49fccf2. The limit here can sometimes exceed the enforced 10000 limit on fetch_materializations.

Test Plan: BK
gibsondan added a commit that referenced this pull request Jul 25, 2024
…asset sensors (#22779)" (#23226)

This reverts commit 49fccf2. The limit
here can sometimes exceed the enforced 10000 limit on
fetch_materializations.

Test Plan: BK

## Summary & Motivation

## How I Tested These Changes
smackesey pushed a commit that referenced this pull request Jul 25, 2024
…asset sensors (#22779)" (#23226)

This reverts commit 49fccf2. The limit
here can sometimes exceed the enforced 10000 limit on
fetch_materializations.

Test Plan: BK

## Summary & Motivation

## How I Tested These Changes
hellendag pushed a commit that referenced this pull request Jul 25, 2024
…asset sensors (#22779)" (#23226)

This reverts commit 49fccf2. The limit
here can sometimes exceed the enforced 10000 limit on
fetch_materializations.

Test Plan: BK

## Summary & Motivation

## How I Tested These Changes
prha added a commit that referenced this pull request Aug 30, 2024
…nsors (#22779)

Uses a fetch batch limit of 1000, to prevent overfetching.

The last vestige of framework calls to `get_event_records`.

BK
prha added a commit that referenced this pull request Sep 3, 2024
…nsors (#22779)

Uses a fetch batch limit of 1000, to prevent overfetching.

The last vestige of framework calls to `get_event_records`.

BK
prha added a commit that referenced this pull request Sep 3, 2024
…nsors (#22779)

Uses a fetch batch limit of 1000, to prevent overfetching.

The last vestige of framework calls to `get_event_records`.

BK
prha added a commit that referenced this pull request Sep 3, 2024
…nsors (#22779) (#24129)

## Summary & Motivation
Uses a fetch batch limit of 1000, to prevent overfetching.

The last vestige of framework calls to `get_event_records`.

## How I Tested These Changes
BK

## Changelog [New]

* Changed data fetching in the multi-asset sensor definition to be less
likely to timeout queries against the asset history storage.
izzye84 pushed a commit that referenced this pull request Sep 4, 2024
…nsors (#22779) (#24129)

## Summary & Motivation
Uses a fetch batch limit of 1000, to prevent overfetching.

The last vestige of framework calls to `get_event_records`.

## How I Tested These Changes
BK

## Changelog [New]

* Changed data fetching in the multi-asset sensor definition to be less
likely to timeout queries against the asset history storage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants