Fix disambiguation routes #21811
Merged
Fix disambiguation routes #21811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengotow
approved these changes
May 13, 2024
salazarm
commented
May 13, 2024
|
|
||
| useBlockTraceUntilTrue('Workspace', loading); | ||
| useBlockTraceUntilTrue('Permissions', permissionsLoading); | ||
| if (loading || permissionsLoading) { |
There was a problem hiding this comment.
Since this site uses useRepository it's also secretly depending on the RootWorkspaceQuery being loaded.
salazarm
added a commit
that referenced
this pull request
May 13, 2024
## Summary & Motivation In a previous PR I removed a waterfall on the WorkspaceQuery since many of the child routes of `WorkspaceRoot` do not actually depend on it. Well in removing that I made a bug that was previously pretty intermittent / infrequent happen all the time. In particular there were routes that were depending on the permissions query without actually waiting for it. Instead those routes happened to be waiting on the WorkspaceQuery which would normally come back after the permissions query hence why the routes worked before. The reason this bug happened intermittently before is because sometimes the WorkspaceQuery would come back before the permissions query causing this bug. To fix this I make the routes wait for permissions to load directly. ## How I Tested These Changes Loaded this page Via app-cloud-proxy and saw that we went to the launch pad: https://localhost:3001/elementl/prod/locations/dagster_open_platform/pipeline_or_job/dagster_quickstart_validation_job/playground/setup?config=%7B%7D%0A&tags%5B0%5D%5Bkey%5D=dagster%2Fsensor_name&tags%5B0%5D%5Bvalue%5D=dagster_quickstart_validation_sensor&tags%5B0%5D%5B__typename%5D=PipelineTag
danielgafni
pushed a commit
to danielgafni/dagster
that referenced
this pull request
Jun 18, 2024
## Summary & Motivation In a previous PR I removed a waterfall on the WorkspaceQuery since many of the child routes of `WorkspaceRoot` do not actually depend on it. Well in removing that I made a bug that was previously pretty intermittent / infrequent happen all the time. In particular there were routes that were depending on the permissions query without actually waiting for it. Instead those routes happened to be waiting on the WorkspaceQuery which would normally come back after the permissions query hence why the routes worked before. The reason this bug happened intermittently before is because sometimes the WorkspaceQuery would come back before the permissions query causing this bug. To fix this I make the routes wait for permissions to load directly. ## How I Tested These Changes Loaded this page Via app-cloud-proxy and saw that we went to the launch pad: https://localhost:3001/elementl/prod/locations/dagster_open_platform/pipeline_or_job/dagster_quickstart_validation_job/playground/setup?config=%7B%7D%0A&tags%5B0%5D%5Bkey%5D=dagster%2Fsensor_name&tags%5B0%5D%5Bvalue%5D=dagster_quickstart_validation_sensor&tags%5B0%5D%5B__typename%5D=PipelineTag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
In a previous PR I removed a waterfall on the WorkspaceQuery since many of the child routes of
WorkspaceRootdo not actually depend on it.Well in removing that I made a bug that was previously pretty intermittent / infrequent happen all the time. In particular there were routes that were depending on the permissions query without actually waiting for it. Instead those routes happened to be waiting on the WorkspaceQuery which would normally come back after the permissions query hence why the routes worked before.
The reason this bug happened intermittently before is because sometimes the WorkspaceQuery would come back before the permissions query causing this bug.
To fix this I make the routes wait for permissions to load directly.
How I Tested These Changes
Loaded this page Via app-cloud-proxy and saw that we went to the launch pad: https://localhost:3001/elementl/prod/locations/dagster_open_platform/pipeline_or_job/dagster_quickstart_validation_job/playground/setup?config=%7B%7D%0A&tags%5B0%5D%5Bkey%5D=dagster%2Fsensor_name&tags%5B0%5D%5Bvalue%5D=dagster_quickstart_validation_sensor&tags%5B0%5D%5B__typename%5D=PipelineTag