[dagster-airbyte] fix auto materialize policies not getting passed through to underlying asset #21158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @jamiedemaria and the rest of your teammates on |
|
@OwenKephart tagging you for general AMP stuff in case anything in this PR could collide with your plans |
benpankow
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
resolves #18266
auto materialize policies were not being passed to the underlying asset correctly. This didn't show up in tests because we didnt check that the
auto_materialize_policies_by_keydict was non empty.This PR also adds an
auto_materialize_policyparam tobuild_airbyte_assetsto bring it to parity with thefrom_instanceandfrom_projectbuilders. If there is a reason this wasn't done to begin with let me know and i can removeHow I Tested These Changes
unit tests