Update examples to remove Dagster code from __init__.py (part 2) #20809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @maximearmstrong and the rest of your teammates on |
2cb2c96
to
193dfaf
Compare
193dfaf
to
92c0918
Compare
sryza
approved these changes
Jul 24, 2024
sryza
pushed a commit
that referenced
this pull request
Jul 24, 2024
) ## Summary & Motivation Part 2 of #20771. This PR updates `assets*` and `experimental/*` examples. Examples that we should be updated when we update the docs: - doc_snippets - project_* - tutorial* Edit 07/24: Updated to match changes in PR #23155 ## How I Tested These Changes Each example was tested locally + BK
maximearmstrong
added a commit
that referenced
this pull request
Aug 2, 2024
## Summary & Motivation Following the fix in #23325 Some examples that were updated in #23155 and #20809 have a `dagster_cloud.yaml` file. This PR makes sure that dagster_cloud.yaml is updated for examples that are now using `definitions.py` instead of `__init__.py`. Quickstart examples were fixed in #23325.
jmsanders
pushed a commit
that referenced
this pull request
Aug 2, 2024
## Summary & Motivation Following the fix in #23325 Some examples that were updated in #23155 and #20809 have a `dagster_cloud.yaml` file. This PR makes sure that dagster_cloud.yaml is updated for examples that are now using `definitions.py` instead of `__init__.py`. Quickstart examples were fixed in #23325. (cherry picked from commit 278e490)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Part 2 of #20771. This PR updates
assets*andexperimental/*examples.Examples that we should be updated when we update the docs:
Edit 07/24:
Updated to match changes in PR #23155
How I Tested These Changes
Each example was tested locally + BK