update ChangeReason.INPUTS to ChangeReason.DEPENDENCIES #20794
Merged
+19
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @jamiedemaria and the rest of your teammates on |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 691f7d7. |
533547e
to
79e1bcf
Compare
This was referenced Mar 29, 2024
salazarm
approved these changes
Apr 2, 2024
79e1bcf
to
691f7d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
we should refer to the INPUTS change reason as a DEPENDENCIES change reason since dependencies is I/O manager agnostic and inputs carries a heavier connotation that it in input data that has changed
internal pr https://github.com/dagster-io/internal/pull/9030
How I Tested These Changes
updated unit tests, ran shadow dagit on our deployment and saw the name update