[external-renames] ExternalTargetData -> TargetSnap #20787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
003b588
to
82ff688
Compare
85a10ca
to
ddd5a2d
Compare
This was referenced Mar 28, 2024
ddd5a2d
to
71c8f79
Compare
schrockn
reviewed
Mar 29, 2024
| @@ -166,7 +166,7 @@ def get_sensors_for_pipeline( | |||
| results = [] | |||
| for external_sensor in external_sensors: | |||
| if pipeline_selector.job_name not in [ | |||
| target.job_name for target in external_sensor.get_external_targets() | |||
| target.job_name for target in external_sensor.get_targets() | |||
There was a problem hiding this comment.
Since we're establishing new conventions, should this be get_target_snaps or get_targets?
There was a problem hiding this comment.
The convention I've been following in this stack is that accessors on a Snap class that return other snaps are not qualified with "snap". Snaps are implicitly understood to contain other snaps.
Open to debate on this but IMO it makes for more readable code in a world where you can use editor hover to get type information for an accessor.
71c8f79
to
697178a
Compare
697178a
to
e1b3f6c
Compare
e1b3f6c
to
0c73a24
Compare
schrockn
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Renames:
ExternalTargetData->TargetSnapHow I Tested These Changes
Existing test suite.