Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[graph differ] [re-introduce] consider partition changes when computing branch diff #20154

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

jamiedemaria
Copy link
Contributor

@jamiedemaria jamiedemaria commented Feb 29, 2024

Reverts #20147 which reverted #19989

Makes the AssetGraphDiffer consider changes to partition definitions and partition mappings as changes in a branch deployment

@jamiedemaria jamiedemaria changed the base branch from master to jamie/differ-rename February 29, 2024 20:47
@jamiedemaria jamiedemaria changed the title Revert "Revert "[graph differ] consider partition changes when determining if…" [graph differ] [re-introduce] consider partition changes when computing branch diff Feb 29, 2024
@jamiedemaria jamiedemaria marked this pull request as ready for review February 29, 2024 21:45
Base automatically changed from jamie/differ-rename to master March 1, 2024 15:44
alangenfeld and others added 2 commits March 1, 2024 10:45
a pin we picked up got yanked

## How I Tested These Changes

bk
@jamiedemaria jamiedemaria force-pushed the revert-20147-jordan/revert-more branch from f8aba1c to 4f003f4 Compare March 1, 2024 15:48
@jamiedemaria jamiedemaria merged commit 2e00b8f into master Mar 1, 2024
1 check passed
@jamiedemaria jamiedemaria deleted the revert-20147-jordan/revert-more branch March 1, 2024 16:22
PedramNavid pushed a commit that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants