Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[graph diff] workspace context can get parent deployment workspace context #19813

Merged
merged 1 commit into from
Feb 20, 2024
Merged

[graph diff] workspace context can get parent deployment workspace context #19813

merged 1 commit into from
Feb 20, 2024

Conversation

jamiedemaria
Copy link
Contributor

@jamiedemaria jamiedemaria commented Feb 14, 2024 •
edited
Loading

Summary & Motivation

We need a way to get the parent workspace context from a branch deployment workspace context. This PR adds get_parent_deployment_context. For OSS, we always return None since there is no concept of a parent deployment

internal PR https://github.com/dagster-io/internal/pull/8280 that implements get_parent_deployment_context for cloud

How I Tested These Changes

This was referenced Feb 14, 2024
Merged
Merged
Closed
Closed
@jamiedemaria
Copy link
Contributor Author

jamiedemaria commented Feb 14, 2024 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

This was referenced Feb 14, 2024
Closed
Merged
Merged
@jamiedemaria jamiedemaria force-pushed the jamie/graphene-repository-takes-workspace-context branch from dc028bc to 7bb4d42 Compare February 14, 2024 22:36
@jamiedemaria jamiedemaria force-pushed the jamie/workspace-context-get-parent-context branch from 38a89bc to 3814448 Compare February 14, 2024 22:37
@jamiedemaria jamiedemaria force-pushed the jamie/graphene-repository-takes-workspace-context branch from 7bb4d42 to 597766d Compare February 14, 2024 22:55
@jamiedemaria jamiedemaria force-pushed the jamie/workspace-context-get-parent-context branch from 3814448 to cc3d694 Compare February 14, 2024 22:55
@jamiedemaria jamiedemaria force-pushed the jamie/graphene-repository-takes-workspace-context branch from 597766d to f32697a Compare February 14, 2024 23:10
@jamiedemaria jamiedemaria force-pushed the jamie/workspace-context-get-parent-context branch from cc3d694 to 9d16e13 Compare February 14, 2024 23:10
@jamiedemaria jamiedemaria force-pushed the jamie/graphene-repository-takes-workspace-context branch from f32697a to ed416fe Compare February 15, 2024 15:57
@jamiedemaria jamiedemaria force-pushed the jamie/workspace-context-get-parent-context branch from 9d16e13 to 13e8f98 Compare February 15, 2024 15:57
@jamiedemaria jamiedemaria force-pushed the jamie/graphene-repository-takes-workspace-context branch from ed416fe to 2f93aca Compare February 15, 2024 20:38
@jamiedemaria jamiedemaria force-pushed the jamie/workspace-context-get-parent-context branch from 13e8f98 to 49a7d8b Compare February 15, 2024 20:38
@jamiedemaria jamiedemaria mentioned this pull request Feb 15, 2024
Closed
@jamiedemaria jamiedemaria force-pushed the jamie/graphene-repository-takes-workspace-context branch from 2f93aca to 8df0b5f Compare February 15, 2024 21:00
@jamiedemaria jamiedemaria force-pushed the jamie/workspace-context-get-parent-context branch from 49a7d8b to 133507c Compare February 15, 2024 21:00
@jamiedemaria jamiedemaria marked this pull request as ready for review February 15, 2024 21:05
@jamiedemaria jamiedemaria force-pushed the jamie/graphene-repository-takes-workspace-context branch from 8df0b5f to b1cd56a Compare February 15, 2024 21:23
@jamiedemaria jamiedemaria force-pushed the jamie/workspace-context-get-parent-context branch from 133507c to 31b78ae Compare February 15, 2024 21:23
@jamiedemaria jamiedemaria force-pushed the jamie/graphene-repository-takes-workspace-context branch from b1cd56a to b637814 Compare February 16, 2024 17:43
@jamiedemaria jamiedemaria force-pushed the jamie/workspace-context-get-parent-context branch from 31b78ae to 6b52422 Compare February 16, 2024 17:43
@jamiedemaria jamiedemaria force-pushed the jamie/graphene-repository-takes-workspace-context branch from b637814 to 12cc57a Compare February 20, 2024 15:17
@jamiedemaria jamiedemaria force-pushed the jamie/workspace-context-get-parent-context branch from 6b52422 to 1e973bf Compare February 20, 2024 15:17
@jamiedemaria jamiedemaria force-pushed the jamie/graphene-repository-takes-workspace-context branch from 12cc57a to 306d965 Compare February 20, 2024 17:07
@jamiedemaria jamiedemaria force-pushed the jamie/workspace-context-get-parent-context branch from 1e973bf to 32c620a Compare February 20, 2024 17:07
Base automatically changed from jamie/graphene-repository-takes-workspace-context to master February 20, 2024 17:56
@jamiedemaria jamiedemaria force-pushed the jamie/workspace-context-get-parent-context branch from 32c620a to f5484ed Compare February 20, 2024 17:58
@jamiedemaria jamiedemaria merged commit 0973a90 into master Feb 20, 2024
1 check passed
@jamiedemaria jamiedemaria deleted the jamie/workspace-context-get-parent-context branch February 20, 2024 18:47
PedramNavid pushed a commit that referenced this pull request Mar 28, 2024
@jamiedemaria @PedramNavid
[graph diff] workspace context can get parent deployment workspace co…
77bf6cc 
…ntext (#19813)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alangenfeld alangenfeld alangenfeld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamiedemaria @alangenfeld