Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asset checks multi asset subsetting #16386

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Asset checks multi asset subsetting #16386

merged 1 commit into from
Sep 8, 2023

Conversation

johannkm
Copy link
Contributor

@johannkm johannkm commented Sep 8, 2023 •
edited

Subset multi assets with checks based on the assets they target.

@johannkm
Copy link
Contributor Author

johannkm commented Sep 8, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@johannkm johannkm force-pushed the johann/09-07-Asset_checks_multi_asset_subsetting branch from 0539bbe to e036268 Compare September 8, 2023 00:52
@johannkm johannkm force-pushed the johann/09-07-Asset_checks_multi_asset_subsetting branch from e036268 to d349950 Compare September 8, 2023 00:55
rexledesma
rexledesma approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@rexledesma rexledesma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

rexledesma
rexledesma requested changes Sep 8, 2023
View reviewed changes
Copy link
Member

@rexledesma rexledesma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a similar issue to #16328. Running this on dbt jaffle shop and doing a subselection generates this log:
Screenshot 2023-09-07 at 9 22 08 PM

@johannkm johannkm force-pushed the johann/09-07-Asset_checks_multi_asset_subsetting branch from d349950 to 08decf1 Compare September 8, 2023 01:34
@johannkm
Copy link
Contributor Author

johannkm commented Sep 8, 2023

Technically it is skipping outputs... should we have this log at all for the dbt case? Seems like it would always be noisy?

If we should have it, maybe we could do the see more... modal thing on the front end to make it smaller in the logs, and leave in checks...

@johannkm
Copy link
Contributor Author

johannkm commented Sep 8, 2023 •
edited

#16328 fixed that we were incorrectly logging that the check didn't run when it actually did- here we're correctly logging that it didn't run, it's just a question of if users care. In the DBT case it's too noisy, but if I define my own multi_asset with 2 assets and 2 checks it might be useful

@johannkm johannkm merged commit fe277ed into master Sep 8, 2023
1 check passed
@johannkm johannkm deleted the johann/09-07-Asset_checks_multi_asset_subsetting branch September 8, 2023 14:39
zyd14 pushed a commit to zyd14/dagster that referenced this pull request Sep 15, 2023
@johannkm @zyd14
Asset checks multi asset subsetting (dagster-io#16386)
d76524a 
Subset multi assets with checks based on the assets they target.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rexledesma rexledesma rexledesma approved these changes

@OwenKephart OwenKephart Awaiting requested review from OwenKephart

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johannkm @rexledesma