Bring back the info output on the dagster-webserver CLI #16357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rexledesma
approved these changes
Sep 7, 2023
Summary: since uvicorn INFO output is spammy but dagster INFO output is not (and adding a WARNING about what port you're running on seems like overkill), split it out into two separate CLI args: --dagster-log-level and --uvicorn-log-level. Not in love with this solution but it was the best I could find that still allowed customziing each of the various knobs while leaving the default dagster dev experience reasonable. Test Plan: Run default 'dagster dev' command - see info level dagster logs in dagster-webserver, but no uvicorn logs Run 'dagster-webserver --uvicorn-log-level INFO --dagster-log-level WARNING` - see just uvicorn logs at the INFO level Run 'dagster dev --log-level DEBUG` - see it affect both daemon output and dagster webserver logs, but not uvicorn traces
ae580fd
to
33eaaf9
Compare
gibsondan
added a commit
that referenced
this pull request
Sep 7, 2023
Summary: since uvicorn INFO output is spammy but dagster INFO output is not (and adding a WARNING about what port you're running on seems like overkill), split it out into two separate CLI args: --dagster-log-level and --uvicorn-log-level. Not in love with this solution but it was the best I could find that still allowed customziing each of the various knobs while leaving the default dagster dev experience reasonable. Test Plan: Run default 'dagster dev' command - see info level dagster logs in dagster-webserver, but no uvicorn logs Run 'dagster-webserver --uvicorn-log-level INFO --dagster-log-level WARNING` - see just uvicorn logs at the INFO level Run 'dagster dev --log-level DEBUG` - see it affect both daemon output and dagster webserver logs, but not uvicorn traces ## Summary & Motivation ## How I Tested These Changes
zyd14
pushed a commit
to zyd14/dagster
that referenced
this pull request
Sep 15, 2023
…6357) Summary: since uvicorn INFO output is spammy but dagster INFO output is not (and adding a WARNING about what port you're running on seems like overkill), split it out into two separate CLI args: --dagster-log-level and --uvicorn-log-level. Not in love with this solution but it was the best I could find that still allowed customziing each of the various knobs while leaving the default dagster dev experience reasonable. Test Plan: Run default 'dagster dev' command - see info level dagster logs in dagster-webserver, but no uvicorn logs Run 'dagster-webserver --uvicorn-log-level INFO --dagster-log-level WARNING` - see just uvicorn logs at the INFO level Run 'dagster dev --log-level DEBUG` - see it affect both daemon output and dagster webserver logs, but not uvicorn traces ## Summary & Motivation ## How I Tested These Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
since uvicorn INFO output is spammy but dagster INFO output is not (and adding a WARNING about what port you're running on seems like overkill), split it out into two separate CLI args: --dagster-log-level and --uvicorn-log-level. Not in love with this solution but it was the best I could find that still allowed customziing each of the various knobs while leaving the default dagster dev experience reasonable.
Test Plan:
Run default 'dagster dev' command - see info level dagster logs in dagster-webserver, but no uvicorn logs
Run 'dagster-webserver --uvicorn-log-level INFO --dagster-log-level WARNING
- see just uvicorn logs at the INFO level Run 'dagster dev --log-level DEBUG- see it affect both daemon output and dagster webserver logs, but not uvicorn tracesSummary & Motivation
How I Tested These Changes