Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ExtResource to ExtClient #16351

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Rename ExtResource to ExtClient #16351

merged 2 commits into from
Sep 7, 2023

Conversation

schrockn
Copy link
Member

@schrockn schrockn commented Sep 6, 2023

Summary & Motivation

Making the ext clients not inherit from ConfigurableResource. Accordingly renaming to ExtClient.

How I Tested These Changes

BK

@schrockn
Copy link
Member Author

schrockn commented Sep 6, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

This was referenced Sep 6, 2023
Merged
Merged
Merged
smackesey
smackesey approved these changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@smackesey smackesey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Maybe rename _core/ext/resource.py -> client.py

@schrockn
Copy link
Member Author

schrockn commented Sep 7, 2023 •
edited
Loading

Merge Activity

@schrockn schrockn merged commit e62c14f into master Sep 7, 2023
1 check passed
@schrockn schrockn deleted the make-clients-POPO-1 branch September 7, 2023 16:34
zyd14 pushed a commit to zyd14/dagster that referenced this pull request Sep 15, 2023
@schrockn @zyd14
Rename ExtResource to ExtClient (dagster-io#16351)
615476d 
## Summary & Motivation

Making the ext clients not inherit from `ConfigurableResource`. Accordingly renaming to `ExtClient`.

## How I Tested These Changes

BK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smackesey smackesey smackesey approved these changes

@alangenfeld alangenfeld Awaiting requested review from alangenfeld

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schrockn @smackesey