Check that check specs target the asset(s) they're defined on #16329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
944e253
to
f3f67d3
Compare
johannkm
commented
Sep 6, 2023
| def test_multi_asset_with_check(): | ||
| @multi_asset( | ||
| outs={"one": AssetOut("asset1"), "two": AssetOut("asset2")}, | ||
| check_specs=[AssetCheckSpec("check1", asset="asset1", description="desc")], | ||
| check_specs=[ | ||
| AssetCheckSpec("check1", asset=AssetKey(["asset1", "one"]), description="desc") |
There was a problem hiding this comment.
all these multi asset test cases had the checks pointing at a non existent asset, since outs={"one": AssetOut("asset1") actually createsAssetKey(["asset1", "one"]).
I was very surprised that asset1 in AssetOut("asset1") becomes the key prefix, not the key.
There was a problem hiding this comment.
@schrockn more fodder against prefixes
f3f67d3
to
2cbc784
Compare
2cbc784
to
fe5b055
Compare
rexledesma
approved these changes
Sep 7, 2023
zyd14
pushed a commit
to zyd14/dagster
that referenced
this pull request
Sep 15, 2023
…r-io#16329) Catch typos when you're defining asset check specs. Removes the ability to execute a check on a different asset than the one who's Op it shares. Context: https://elementl-workspace.slack.com/archives/C05KFG9TETB/p1693969799827069
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch typos when you're defining asset check specs. Removes the ability to execute a check on a different asset than the one who's Op it shares.
Context: https://elementl-workspace.slack.com/archives/C05KFG9TETB/p1693969799827069