Fix asset checks + key prefixes #16327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
987865f
to
ef36e90
Compare
rexledesma
approved these changes
Sep 6, 2023
ef36e90
to
9217d64
Compare
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 9217d64. |
zyd14
pushed a commit
to zyd14/dagster
that referenced
this pull request
Sep 15, 2023
Context: https://elementl-workspace.slack.com/archives/C05KFG9TETB/p1693931080865119?thread_ts=1693924159.102829&cid=C05KFG9TETB This is a breaking change that will always require `@asset_check(` to have an `asset`. I think this isn't too bad ergonomically, though it does mean repeating in the io manager case: ```python @asset_check(asset=my_asset) def my_check(my_asset): ... ``` At present I think this is required, because we use asset groups for resolving keys to the fully prefixed keys, and we don't know the group of a check until we resolve which asset it points at.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://elementl-workspace.slack.com/archives/C05KFG9TETB/p1693931080865119?thread_ts=1693924159.102829&cid=C05KFG9TETB
This is a breaking change that will always require
@asset_check(to have anasset. I think this isn't too bad ergonomically, though it does mean repeating in the io manager case:At present I think this is required, because we use asset groups for resolving keys to the fully prefixed keys, and we don't know the group of a check until we resolve which asset it points at.