feat(dbt): allow dbt tests to be modeled as asset checks #16324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
e892520
to
e352623
Compare
johannkm
approved these changes
Sep 6, 2023
python_modules/libraries/dagster-dbt/dagster_dbt/core/resources_v2.py
Outdated
Show resolved
Hide resolved
johannkm
reviewed
Sep 6, 2023
python_modules/libraries/dagster-dbt/dagster_dbt/asset_utils.py
Outdated
Show resolved
Hide resolved
e352623
to
cad2931
Compare
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit cad2931. |
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-i6gg0v693-elementl.vercel.app Direct link to changed pages: |
cad2931
to
5e1ce9d
Compare
2dc4f7a
to
0e0110e
Compare
5e1ce9d
to
bd5d7c7
Compare
88de858
to
f8c9ab8
Compare
0e0110e
to
7f47784
Compare
f8c9ab8
to
0b6b8fa
Compare
Base automatically changed from
rl/add-test-dbt-project-dagster-asset-checks
to
master
September 6, 2023 20:12
0b6b8fa
to
87da810
Compare
zyd14
pushed a commit
to zyd14/dagster
that referenced
this pull request
Sep 15, 2023
…16324) ## Summary & Motivation As the title. Currently, users will have to opt-in to modelling their dbt tests as Dagster asset checks. This is because the API's for asset checks are currently experimental, and we do not want to break users of the public stable API's for ingesting dbt models as Dagster software-defined assets. So, to enable this feature, users will have to configure the following metadata on their dbt project tests: ```yaml # dbt_project.yml tests: +meta: dagster: asset_check: True ``` Or, tests can be individually turned on using the dbt config block or property file: https://docs.getdbt.com/reference/test-configs#test-specific-configurations. ## How I Tested These Changes pytest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
As the title.
Currently, users will have to opt-in to modelling their dbt tests as Dagster asset checks. This is because the API's for asset checks are currently experimental, and we do not want to break users of the public stable API's for ingesting dbt models as Dagster software-defined assets.
So, to enable this feature, users will have to configure the following metadata on their dbt project tests:
Or, tests can be individually turned on using the dbt config block or property file: https://docs.getdbt.com/reference/test-configs#test-specific-configurations.
How I Tested These Changes
pytest