[ext] Condense dagster-ext package to one file
#16321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
dd8276f
to
9549926
Compare
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 9549926. |
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-4bwno6f5y-elementl.vercel.app Direct link to changed pages: |
schrockn
requested changes
Sep 6, 2023
Comment on lines
699
to
732
| # ######################## | ||
| # ##### PUBLIC API | ||
| # ######################## | ||
|
|
||
| # Defining `__all__` would be redundant for purposes of formalizing the public API, since | ||
| # type-checkers will count any non-underscored symbol defined in this module as public. However, it | ||
| # is useful to maintain a whitelist of intended-to-be-public symbols for development and | ||
| # documentation purposes. | ||
|
|
||
| # ExtContext as ExtContext, | ||
| # init_dagster_ext as init_dagster_ext, | ||
| # ExtContextLoader as ExtContextLoader, | ||
| # ExtBlobStoreMessageWriter as ExtBlobStoreMessageWriter, | ||
| # ExtBlobStoreMessageWriterChannel as ExtBlobStoreMessageWriterChannel, | ||
| # ExtMessageWriter as ExtMessageWriter, | ||
| # ExtMessageWriterChannel as ExtMessageWriterChannel, | ||
| # ExtParamLoader as ExtParamLoader, | ||
| # ExtDefaultContextLoader as ExtDefaultContextLoader, | ||
| # ExtDefaultMessageWriter as ExtDefaultMessageWriter, | ||
| # ExtEnvContextLoader as ExtEnvContextLoader, | ||
| # ExtS3MessageWriter as ExtS3MessageWriter, | ||
| # DAGSTER_EXT_ENV_KEYS as DAGSTER_EXT_ENV_KEYS, | ||
| # ExtContextData as ExtContextData, | ||
| # ExtDataProvenance as ExtDataProvenance, | ||
| # ExtExtras as ExtExtras, | ||
| # ExtMessage as ExtMessage, | ||
| # ExtParams as ExtParams, | ||
| # ExtPartitionKeyRange as ExtPartitionKeyRange, | ||
| # ExtTimeWindow as ExtTimeWindow, | ||
| # DagsterExtError as DagsterExtError, | ||
| # DagsterExtWarning as DagsterExtWarning, | ||
| # decode_env_var as decode_env_var, | ||
| # encode_env_var as encode_env_var, | ||
| # is_dagster_orchestration_active as is_dagster_orchestration_active, |
There was a problem hiding this comment.
hmmm very skeptical of the utility of this. almost certainly will fall out of date
There was a problem hiding this comment.
fair, it was more useful while I was picking out the methods to underscore than it is now, removed
9549926
to
326d28c
Compare
schrockn
approved these changes
Sep 6, 2023
zyd14
pushed a commit
to zyd14/dagster
that referenced
this pull request
Sep 15, 2023
## Summary & Motivation Condenses `dagster-ext` into a single file `dagster_ext/__init__.py` so it can be vendored easily. I didn't go all the way to just `dagster_ext.py` so that I could leave `dagster_ext/version.py` and `dagster_ext/py.typed`. It should be just as easy to copy-paste the file contents from `__init__.py`. ## How I Tested These Changes Existing test suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Condenses
dagster-extinto a single filedagster_ext/__init__.pyso it can be vendored easily.I didn't go all the way to just
dagster_ext.pyso that I could leavedagster_ext/version.pyanddagster_ext/py.typed. It should be just as easy to copy-paste the file contents from__init__.py.How I Tested These Changes
Existing test suite.