Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dbt): remove empty manifest argument in scaffold #16218

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

rexledesma
Copy link
Member

Summary & Motivation

This should be landed after #16217 has been released.

How I Tested These Changes

N/A

@rexledesma
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@rexledesma rexledesma self-assigned this Aug 30, 2023
@github-actions
Copy link

github-actions bot commented Aug 30, 2023

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-bff1aawtf-elementl.vercel.app
https://rl-make-manifest-optional-in-scaffold.dagster.dagster-docs.io

Direct link to changed pages:

Base automatically changed from rl/make-manifest-optional to master August 31, 2023 01:09
@rexledesma rexledesma force-pushed the rl/make-manifest-optional-in-scaffold branch from 8419191 to 2eb5cda Compare September 7, 2023 21:28
@rexledesma rexledesma merged commit e0f5dcf into master Sep 7, 2023
3 of 4 checks passed
@rexledesma rexledesma deleted the rl/make-manifest-optional-in-scaffold branch September 7, 2023 21:29
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-ke8yas9ta-elementl.vercel.app
https://rl-make-manifest-optional-in-scaffold.core-storybook.dagster-docs.io

Built with commit 2eb5cda.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-icmt3up71-elementl.vercel.app
https://rl-make-manifest-optional-in-scaffold.components-storybook.dagster-docs.io

Built with commit 2eb5cda.
This pull request is being automatically deployed with vercel-action

zyd14 pushed a commit to zyd14/dagster that referenced this pull request Sep 15, 2023
…6218)

## Summary & Motivation
This should be landed after
dagster-io#16217 has been released.

## How I Tested These Changes
N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants