Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markdown links in changelog #12877

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

johannkm
Copy link
Contributor

Summary & Motivation

Does this pull request update the docs? If so, please verify that the updates follow the docs style checklist.


How I Tested These Changes

@vercel
Copy link

vercel bot commented Mar 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
dagster ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 10, 2023 at 3:31PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
dagit-storybook ⬜️ Ignored (Inspect) Mar 10, 2023 at 3:31PM (UTC)

@johannkm
Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

CHANGES.md Outdated
@@ -121,7 +122,7 @@ Stay tuned, as this is only the first part of the overhaul. We’ll be adding mo

### Documentation

- The [Asset Versioning and Caching Guide]([https://docs.dagster.io/guides/dagster/asset-versioning-and-caching](https://docs.dagster.io/guides/dagster/asset-versioning-and-caching)) now includes a section on user-provided data versions
- The [Asset Versioning and Caching Guide](<[https://docs.dagster.io/guides/dagster/asset-versioning-and-caching](https://docs.dagster.io/guides/dagster/asset-versioning-and-caching)>) now includes a section on user-provided data versions
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with (<[https://some.link]>) syntax-- normally I would just use (https://some.link)? But if it works np.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't notice that, my editor added those. I guess bc it had the broken double link

@johannkm johannkm merged commit fa086c7 into master Mar 10, 2023
@johannkm johannkm deleted the johann/03-10-Fix_markdown_links_in_changelog branch March 10, 2023 15:35
prha pushed a commit that referenced this pull request Mar 10, 2023
## Summary & Motivation

> **Does this pull request update the docs?** If so, please verify that
the updates follow the [docs style
checklist](https://github.com/dagster-io/dagster/blob/master/docs/DOC_CHECKLIST.md).

---

## How I Tested These Changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants