Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add volatility property to CachingStaleStatusResolver #12855

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

smackesey
Copy link
Collaborator

Summary & Motivation

  • Add _is_volatile on CachingStaleStatusResolver.
    • This required exposing observability on AssetGraph.
  • Remove StaleRootCause, which is dead code that should've been previously removed.

How I Tested These Changes

BK

No new tests since this property is at present internal to the CachingStaleStatusResolver and not used for anything. Testing will be done on the outputs of CachingStaleStatusResolver that volatility informs.

@vercel
Copy link

vercel bot commented Mar 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated
dagit-storybook ⬜️ Ignored (Inspect) Mar 9, 2023 at 9:56PM (UTC)
dagster ⬜️ Ignored (Inspect) Mar 9, 2023 at 9:56PM (UTC)

@smackesey
Copy link
Collaborator Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@smackesey smackesey marked this pull request as ready for review March 9, 2023 20:02
Copy link
Contributor

@OwenKephart OwenKephart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be good to put some common situations under test but the logic looks good

@smackesey
Copy link
Collaborator Author

would be good to put some common situations under tes

Prefer to avoid this atm since right now _is_volatile is just an implementation detail of CachingStaleStatusResolver. If we expose it, then I would support testing it directly the way the public API is tested

@smackesey smackesey merged commit b8014b9 into master Mar 9, 2023
@smackesey smackesey deleted the sean/add-is-volatile branch March 9, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants