Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asset list command #12790

Merged
merged 1 commit into from
Mar 10, 2023
Merged

asset list command #12790

merged 1 commit into from
Mar 10, 2023

Conversation

sryza
Copy link
Contributor

@sryza sryza commented Mar 8, 2023

Summary & Motivation

How I Tested These Changes

@vercel
Copy link

vercel bot commented Mar 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated
dagit-storybook ⬜️ Ignored (Inspect) Mar 10, 2023 at 0:35AM (UTC)
dagster ⬜️ Ignored (Inspect) Mar 10, 2023 at 0:35AM (UTC)

Copy link
Contributor

@OwenKephart OwenKephart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@@ -81,6 +81,34 @@ def execute_materialize_command(instance: DagsterInstance, kwargs: Mapping[str,
)


@asset_cli.command(name="list", help="List assets")
@python_origin_target_argument
@click.option("--select", help="Asset selection to target", required=False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Asset selection" is a bit of a fraught term but I think it works here. Should we at least add some examples (e.g. "prefixed/asset*")?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to address this in a followup after adding asset selection syntax docs that we can link to: #12871

@sryza sryza mentioned this pull request Mar 8, 2023
Base automatically changed from asset-cli to master March 10, 2023 00:34
@sryza sryza merged commit f49dc0a into master Mar 10, 2023
@sryza sryza deleted the list-command branch March 10, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants