Chore: Internal backends should not fail CI #5573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until the Rust code generator is finished, we shouldn't block everyone else's work by requiring .rs.check files or even update them every time, since the process is manual and very lengthy
keyboardDrummer
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until the Rust code generator is finished, we shouldn't block everyone else's work by requiring .rs.check files or even update them every time, since the process is manual and very lengthy
This does not remove the execution of the Rust compiler, only remove the check, so that we still have some kind of coverage. Also, we display non-blocking error messages.
However, this might kill the meta-tests, I'll see how to fix that.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.