Split off parts of single pass compiler #5526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikaelMayer
previously approved these changes
Jun 4, 2024
| var wElse = EmitBlock(wr); | ||
| EmitAbsurd("unreachable alternative", wElse); | ||
|
|
||
| } else if (stmt is WhileStmt) { |
There was a problem hiding this comment.
While you're at it and this is a refactoring, could you use your IDE to convert this chain of if-else into a switch statement? It will make debugging much easier.
There was a problem hiding this comment.
sure. I'll do it in the follow-up, so I don't have to do it twice.
MikaelMayer
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How has this been tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.