Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Double shard count and drop ubuntu-lastest from the nightly build #5518

Merged
merged 6 commits into from
Jun 3, 2024
Merged

chore: Double shard count and drop ubuntu-lastest from the nightly build #5518

merged 6 commits into from
Jun 3, 2024

Conversation

fabiomadge
Copy link
Collaborator

Should make make the nightly build more predictable

@fabiomadge fabiomadge added the run-deep-tests Tells CI to run all tests label Jun 3, 2024
@fabiomadge fabiomadge requested a review from robin-aws June 3, 2024 19:40
robin-aws
robin-aws approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@robin-aws robin-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't want to block on it in favor of merging ASAP, but we should also change the num_shards: 5 line in msbuild.yml to be 10 when run-deep-tests is true as well, just so we don't get false negatives when fixing the nightly build.

@robin-aws
Copy link
Member

Bypassing required checks since this is hitting other unrelated build flakiness

@robin-aws robin-aws merged commit da8b84f into dafny-lang:master Jun 3, 2024
22 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robin-aws robin-aws robin-aws approved these changes

Assignees
No one assigned
Labels
run-deep-tests Tells CI to run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fabiomadge @robin-aws