Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement assigned(e) expression #5501

Merged
merged 8 commits into from
May 30, 2024
Merged

Conversation

alex-chew
Copy link
Contributor

@alex-chew alex-chew commented May 28, 2024

Description

Implements the assigned(e) expression, fixing #5251.

Tasks:

  • Add assigned(e) to grammar and translator
  • Add tests
  • Add DefiniteAssignment proof obligation expression
  • Update documentation

How has this been tested?

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@alex-chew alex-chew requested a review from atomb May 29, 2024 04:16
@alex-chew alex-chew marked this pull request as ready for review May 29, 2024 04:16
@alex-chew alex-chew marked this pull request as draft May 29, 2024 04:16
atomb
atomb previously approved these changes May 29, 2024
Copy link
Member

@atomb atomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as the tests pass once CI is running again, I think this looks good.

@alex-chew alex-chew marked this pull request as ready for review May 29, 2024 21:20
@alex-chew alex-chew enabled auto-merge (squash) May 29, 2024 21:20
atomb
atomb previously approved these changes May 29, 2024
@alex-chew alex-chew merged commit 64853d3 into master May 30, 2024
21 checks passed
@alex-chew alex-chew deleted the alexchew/assigned-keyword branch May 30, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants