Do not emit incorrect linting warnings #5491
Conversation
| @@ -7,6 +7,7 @@ | |||
| //----------------------------------------------------------------------------- | |||
|
|
|||
| using System.Linq; | |||
| using System.Security.AccessControl; | |||
There was a problem hiding this comment.
Where is this needed?
| } else if (expr is FunctionCallExpr functionCallExpr) { | ||
| return VisitComponentsAsIndependentExceptOne(expr, functionCallExpr.Receiver, st); | ||
| } else if (expr is ApplyExpr applyExpr) { | ||
| return VisitComponentsAsIndependentExceptOne(expr, applyExpr.Function, st); |
There was a problem hiding this comment.
If we no longer expect DatatypeValue and FunctionCallExpr to ever arise at this time, then:
- We could still look for them and do a
Contract.Assert(false);(or something similar) if they ever occur. - Is
VisitComponentAsIndependentExceptOnenow unused?
There was a problem hiding this comment.
We could still look for them and do a Contract.Assert(false); (or something similar) if they ever occur.
Any resolution only type is unexpected, since this code runs before resolution now. I don't think it makes sense to look for all resolution-only types and assert false. To be honest, I do not think this file should refer to any AST constructs. Each parsed construct should declare all its grammar specific properties, including what is needed for this linting warning.
Is VisitComponentAsIndependentExceptOne now unused?
No it's still used.
| PrecedenceLinter.dfy(401,43): Warning: unusual indentation in right-hand operand of ==> (which ends at line 402, column 11); do you perhaps need parentheses? | ||
| PrecedenceLinter.dfy(403,43): Warning: unusual indentation in right-hand operand of ==> (which ends at line 404, column 11); do you perhaps need parentheses? | ||
| PrecedenceLinter.dfy(431,11): Warning: unusual indentation in else branch of if-then-else (which ends at line 434, column 6); do you perhaps need parentheses? |
Description
How has this been tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.