Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No memory leaks boogie #5482

Merged
merged 8 commits into from
May 23, 2024
Merged

No memory leaks boogie #5482

merged 8 commits into from
May 23, 2024

Conversation

keyboardDrummer
Copy link
Member

@keyboardDrummer keyboardDrummer commented May 23, 2024 •
edited
Loading

Fixes #5174

Description

  • Update to Boogie 3.1.6, which resolves a bug memory leak
  • Add a try/catch in publishing of gutter icons, to prevent the language server from crashing. Long term plan is to move away from publishing gutter icons on the server altogether, since the information can be derived on the client as well.

How has this been tested?

  • Manually testing using a profiling that repeatedly doing verification no longer causes memory leaks in Dafny

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@keyboardDrummer keyboardDrummer enabled auto-merge (squash) May 23, 2024 12:29
atomb
atomb approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@atomb atomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for doing this!

@keyboardDrummer keyboardDrummer merged commit 5dc56e6 into dafny-lang:master May 23, 2024
21 checks passed
@keyboardDrummer keyboardDrummer deleted the noMemoryLeaksBoogie branch May 23, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomb atomb atomb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

high CPU/RAM usage when should be idle
2 participants
@keyboardDrummer @atomb