Add yet more ProofObligationDescription expressions #5467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uctorValid/NotGhostVariant
atomb
approved these changes
May 20, 2024
| @@ -81,7 +81,7 @@ public partial class BoogieGenerator { | |||
| // FREE PRECONDITIONS | |||
| if (kind == MethodTranslationKind.SpecWellformedness || kind == MethodTranslationKind.Implementation) { // the other cases have no need for a free precondition | |||
| // free requires mh == ModuleContextHeight && fh = FunctionContextHeight; | |||
| req.Add(Requires(iter.tok, true, etran.HeightContext(iter), null, null, null)); | |||
| req.Add(Requires(iter.tok, true, null, etran.HeightContext(iter), null, null, null)); | |||
There was a problem hiding this comment.
At first I was confused by the null parameter here and then realized that these are free requires clauses so they'll never be part of any proof obligation.
| @@ -0,0 +1,6 @@ | |||
| ensures-stronger.dfy(16,2): Error: the method must provide an equal or more detailed postcondition than in its parent trait | |||
| Asserted expression: P(res') ==> b' ==> Q(res') | |||
There was a problem hiding this comment.
This is a nice case where I think seeing the asserted expression is especially helpful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds more ProofObligationDescription asserted expressions, viewable by the previously added --show-proof-obligation-expressions flag.