Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout reporting #5393

Merged
merged 2 commits into from
May 2, 2024
Merged

Timeout reporting #5393

merged 2 commits into from
May 2, 2024

Conversation

keyboardDrummer
Copy link
Member

@keyboardDrummer keyboardDrummer commented May 2, 2024 •
edited
Loading

Fixes #5389

Description

  • Fix bug in reporting of time taken when a verification timeout occurs
  • Make test 3855 stable by redacting the time taken

How has this been tested?

  • Fix is not tested
  • Flaky test is updated

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@keyboardDrummer keyboardDrummer enabled auto-merge (squash) May 2, 2024 08:28
@keyboardDrummer keyboardDrummer mentioned this pull request May 2, 2024
Closed
stefan-aws
stefan-aws approved these changes May 2, 2024
View reviewed changes
Copy link
Collaborator

@stefan-aws stefan-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keyboardDrummer keyboardDrummer merged commit 075b2a8 into dafny-lang:master May 2, 2024
21 checks passed
@keyboardDrummer keyboardDrummer deleted the timeoutReporting branch May 2, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefan-aws stefan-aws stefan-aws approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky test: git-issue-3855.dfy
2 participants
@keyboardDrummer @stefan-aws