Remove warnings with .NET 8.0

Source/DafnyCore/AST/SystemModuleManager.cs

@@ -62,7 +62,7 @@ public class SystemModuleManager {
  Concat(TotalArrowTypeDecls.Keys.OrderBy(x => x)).
  Concat(tupleInts.OrderBy(x => x));
  var bytes = ints.SelectMany(BitConverter.GetBytes).ToArray();
- hash = HashAlgorithm.Create("SHA256")!.ComputeHash(bytes);
+ hash = SHA256.Create()!.ComputeHash(bytes);
  }
 
  return hash;

Source/DafnyCore/DafnyCore.csproj

@@ -20,7 +20,9 @@
  <TargetFramework>net8.0</TargetFramework>
  <PackageLicenseExpression>MIT</PackageLicenseExpression>
 
- <NoWarn>$(NoWarn);NU5104</NoWarn> <!-- Required because System.CommandLine is in beta. -->
+ <NoWarn>$(NoWarn);NU5104;CS8981</NoWarn>
+ <!-- NU5104 required because System.CommandLine is in beta. -->
+ <!-- CS8981 required because Dafny code can use lowercase type names -->
  <IsPackable>true</IsPackable>
  </PropertyGroup>
 

Source/DafnyLanguageServer.Test/Performance/LargeFilesTest.cs

@@ -62,7 +62,7 @@ public class LargeFilesTest : ClientBasedLanguageServerTest {
  var afterChange = DateTime.Now;
  var changeMilliseconds = (afterChange - afterOpen).TotalMilliseconds;
  await AssertNoDiagnosticsAreComing(CancellationTokenWithHighTimeout);
- cancelSource.Cancel();
+ await cancelSource.CancelAsync();
  var averageTimeToSchedule = await measurementTask;
  var division = changeMilliseconds / openMilliseconds;
  lowest = Math.Min(lowest, division);
@@ -114,4 +114,4 @@ public class LargeFilesTest : ClientBasedLanguageServerTest {
 
  public LargeFilesTest(ITestOutputHelper output) : base(output) {
  }
-}
+}

Source/DafnyLanguageServer/Language/CachingParser.cs

@@ -36,7 +36,7 @@ public class CachingParser : ProgramParser {
  // Add NUL delimiter to avoid collisions (otherwise hash("A" + "BC") == hash("AB" + "C"))
  var uriBytes = Encoding.UTF8.GetBytes(uri + "\0");
 
- var (newReader, hash) = ComputeHashFromReader(uriBytes, reader, HashAlgorithm.Create("SHA256")!);
+ var (newReader, hash) = ComputeHashFromReader(uriBytes, reader, SHA256.Create()!);
  if (!parseCache.TryGet(hash, out var result)) {
  logger.LogDebug($"Parse cache miss for {uri}");
  result = base.ParseFile(options, () => newReader, uri, cancellationToken);
@@ -83,4 +83,4 @@ public class CachingParser : ProgramParser {
  result.Add(chunk);
  }
  }
-}
+}

Source/DafnyLanguageServer/Language/CachingResolver.cs

@@ -75,7 +75,7 @@ public class CachingResolver : ProgramResolver {
  private byte[] GetHash(ModuleDecl moduleDeclaration) {
  if (!hashes.TryGetValue(moduleDeclaration, out var result)) {
  var moduleVertex = dependencies.FindVertex(moduleDeclaration);
- var hashAlgorithm = HashAlgorithm.Create("SHA256")!;
+ var hashAlgorithm = SHA256.Create()!;
  hashAlgorithm.Initialize();
  // We don't want the order of Successors to influence the hash, so we order by the content hash, for which CloneId is currently a proxy
  var orderedSuccessors = moduleVertex.Successors.OrderBy(s => s.N.CloneId);
@@ -98,4 +98,4 @@ public class CachingResolver : ProgramResolver {
 
  return result;
  }
-}
+}

Source/DafnyServer/SuperLegacySymbolTable.cs

@@ -227,9 +227,7 @@ public class SuperLegacySymbolTable {
  var updateStmt = (UpdateStmt)statement;
  var leftSide = updateStmt.Lhss;
  var rightSide = updateStmt.Rhss;
- var leftSideDots = leftSide.OfType<ExprDotName>();
- var rightSideDots = rightSide.OfType<ExprDotName>();
- var allExprDotNames = leftSideDots.Concat(rightSideDots);
+ var allExprDotNames = leftSide.OfType<ExprDotName>();
  foreach (var exprDotName in allExprDotNames) {
  if (!(exprDotName.Lhs.Type is UserDefinedType)) {
  continue;
@@ -304,12 +302,8 @@ public class SuperLegacySymbolTable {
  var updateStmt = (UpdateStmt)statement;
  var leftSide = updateStmt.Lhss;
  var rightSide = updateStmt.Rhss;
- var leftSideDots = leftSide.OfType<ExprDotName>();
- var rightSideDots = rightSide.OfType<ExprDotName>();
- var exprDotNames = leftSideDots.Concat(rightSideDots);
- var leftSideNameSegments = leftSide.OfType<NameSegment>();
- var rightSideNameSegments = rightSide.OfType<NameSegment>();
- var nameSegments = leftSideNameSegments.Concat(rightSideNameSegments);
+ var exprDotNames = leftSide.OfType<ExprDotName>();
+ var nameSegments = leftSide.OfType<NameSegment>();
  var allRightSideExpressions = rightSide.SelectMany(e => e.SubExpressions.SelectMany(GetAllSubExpressions));
  var allLeftSideExpressions =
  leftSide.SelectMany(e => e.SubExpressions.SelectMany(GetAllSubExpressions));