Make --filter-* work with measure-complexity
#5264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -49,7 +49,9 @@ public static class DafnyCommands { | |||
| CommonOptionBag.VerificationCoverageReport, | |||
| CommonOptionBag.ExtractCounterexample, | |||
| CommonOptionBag.ShowInference, | |||
| CommonOptionBag.ManualTriggerOption | |||
| CommonOptionBag.ManualTriggerOption, | |||
| CommonOptionBag.FilterSymbol, | |||
There was a problem hiding this comment.
I think VerificationOptions is too wide, because it includes everything that can do verification, such as dafny build and dafny translate. Those commands have no business filtering verification.
I took the liberty of applying the above suggestion and committing it to this PR, and have approved it. If you're OK with this change, feel free to merge. You're also free to revert it and do something else :-)
There was a problem hiding this comment.
I think that's reasonable. I'll merge it as-is with your update.
keyboardDrummer
approved these changes
Mar 28, 2024
auto-merge was automatically disabled
April 8, 2024 09:18
Merge queue setting changed
auto-merge was automatically disabled
April 9, 2024 10:14
Merge queue setting changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make
--filter-positionand--filter-symbolwork withmeasure-complexity.How has this been tested?
Just manually, though those flags are already tested for
dafny verify.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.