-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate almost all CLI tests to use the command based CLI #5255
Migrate almost all CLI tests to use the command based CLI #5255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad we can get most of the tests working with the new test commands, and that it clarifies which tests need relaxed definite assignment. I left a few questions, but none of them are blocking.
@@ -1,3 +1,3 @@ | |||
|
|||
Dafny program verifier finished with 6 verified, 0 errors | |||
Dafny program verifier finished with 7 verified, 0 errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know why this changed? I don't think it's likely a problem, but it's odd that just changing to the new CLI would do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, it's due to the change in default for definite assignment, isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be, but also the previous number was amount of implementations (a concept almost invisible to the user), and the new number is amount of assertion batches (slightly visible).
@@ -1,5 +1,5 @@ | |||
// NONUNIFORM: need to add support for tooltips to the new CLI (if that makes sense) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this comment obsolete now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the test
// RUN: %diff "%s.expect" "%t" | ||
|
||
type MyType // compile error: abstract type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused about this change. It should still be a compile error, shouldn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know. The type is not used by the rest of the code, maybe that matters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved last two commits
Description
How has this been tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.