Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate almost all CLI tests to use the command based CLI #5255

Merged

Conversation

keyboardDrummer
Copy link
Member

@keyboardDrummer keyboardDrummer commented Mar 27, 2024

Description

  • Migrate almost all CLI tests to use the command based CLI
  • Tests that use options that are only available in the old CLI have not been migrated

How has this been tested?

  • The tests themselves have changed

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@keyboardDrummer keyboardDrummer marked this pull request as ready for review March 29, 2024 11:01
@keyboardDrummer keyboardDrummer changed the title Move cli tests to new cli Migrate almost all CLI tests to use the command based CLI Mar 29, 2024
@keyboardDrummer keyboardDrummer enabled auto-merge (squash) March 29, 2024 11:02
atomb
atomb previously approved these changes Mar 29, 2024
Copy link
Member

@atomb atomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad we can get most of the tests working with the new test commands, and that it clarifies which tests need relaxed definite assignment. I left a few questions, but none of them are blocking.

@@ -1,3 +1,3 @@

Dafny program verifier finished with 6 verified, 0 errors
Dafny program verifier finished with 7 verified, 0 errors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why this changed? I don't think it's likely a problem, but it's odd that just changing to the new CLI would do this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it's due to the change in default for definite assignment, isn't it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be, but also the previous number was amount of implementations (a concept almost invisible to the user), and the new number is amount of assertion batches (slightly visible).

@@ -1,5 +1,5 @@
// NONUNIFORM: need to add support for tooltips to the new CLI (if that makes sense)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment obsolete now?

Copy link
Member Author

@keyboardDrummer keyboardDrummer Apr 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the test

// RUN: %diff "%s.expect" "%t"

type MyType // compile error: abstract type
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused about this change. It should still be a compile error, shouldn't it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. The type is not used by the rest of the code, maybe that matters.

atomb
atomb previously approved these changes Apr 1, 2024
Copy link
Member

@MikaelMayer MikaelMayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved last two commits

@keyboardDrummer keyboardDrummer merged commit 5c8806f into dafny-lang:master Apr 3, 2024
20 checks passed
@keyboardDrummer keyboardDrummer deleted the moveCliTestsToNewCli branch April 3, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants