Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate assertions attribute #5247

Merged

Conversation

keyboardDrummer
Copy link
Member

Description

Add {:isolate_assertions} attribute, that has the same meaning as {:vcs_split_on_every_assert}

How has this been tested?

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@keyboardDrummer keyboardDrummer marked this pull request as ready for review March 25, 2024 15:33
@keyboardDrummer keyboardDrummer enabled auto-merge (squash) March 25, 2024 15:34
Copy link
Member

@MikaelMayer MikaelMayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this new attribute, will save me a few keystrokes when debugging verification.

Verified part 2/3 of Foo, on line 6 (redacted, resource count: 3.1E+003)
Verified part 3/3 of Foo, on line 7 (redacted, resource count: 2.8E+003)
Verified 1/2 symbols. Waiting for Bar to verify.
Verified part 1/1 of Bar, on line 10 (redacted, resource count: 3.1E+003)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I did not know about --progress but it's great that you can have a non-brittle test that will test it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's brand new :-D

docs/DafnyRef/Attributes.md Outdated Show resolved Hide resolved
docs/dev/news/5247.feat Outdated Show resolved Hide resolved
Copy link
Member

@MikaelMayer MikaelMayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@keyboardDrummer keyboardDrummer merged commit ca4bb03 into dafny-lang:master Mar 27, 2024
20 checks passed
@keyboardDrummer keyboardDrummer deleted the isolateAssertionsAttribute branch March 27, 2024 18:00
robin-aws pushed a commit that referenced this pull request Mar 27, 2024
### Description
Add `{:isolate_assertions}` attribute, that has the same meaning as
`{:vcs_split_on_every_assert}`

### How has this been tested?
<!-- Tests can be added to
`Source/IntegrationTests/TestFiles/LitTests/LitTest/` or to
`Source/*.Test/…` and run with `dotnet test` -->

<small>By submitting this pull request, I confirm that my contribution
is made under the terms of the [MIT
license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants