fix: Generate proper default string value for JavaScript #5239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyboardDrummer
previously approved these changes
Mar 22, 2024
fabiomadge
reviewed
Mar 22, 2024
| @@ -974,7 +974,7 @@ protected class ClassWriter : IClassWriter { | |||
| return $"{DafnyMultiSetClass}.Empty"; | |||
| } else if (xType is SeqType seq) { | |||
| if (seq.Arg.IsCharType) { | |||
| return "''"; | |||
| return "_dafny.Seq.UnicodeFromString('')"; | |||
There was a problem hiding this comment.
Does this still support --unicode-char=false?
There was a problem hiding this comment.
Good call. The answer happens to be "yes", and I really mean "happens to". I changed the code to treat the two cases separately.
In writing more test cases, I also ran across the known non-uniformity with the printing of empty strings in Python. I was able to remove this non-uniformity for the default string.
fabiomadge
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5238
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.