Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update general-traits error message #5191

Merged
merged 14 commits into from
Mar 14, 2024

Conversation

RustanLeino
Copy link
Collaborator

Previously, the error message for using extends with a non-reference type said that this was a beta feature. It is supported, but requires the CLI option. This PR rewords these error messages.

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@RustanLeino RustanLeino marked this pull request as ready for review March 13, 2024 19:25
@RustanLeino RustanLeino enabled auto-merge (squash) March 13, 2024 22:06
robin-aws
robin-aws previously approved these changes Mar 13, 2024
Copy link
Member

@robin-aws robin-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made suggestions to fix an existing typo and improve existing wording, but going to merge anyway as I don't want to force another CI run right this second. Feel free to ignore or integrate into a future PR.

docs/HowToFAQ/Errors-Parser.template Outdated Show resolved Hide resolved
Source/DafnyCore/AST/Grammar/ParseErrors.cs Outdated Show resolved Hide resolved
Source/DafnyCore/Dafny.atg Outdated Show resolved Hide resolved
Source/DafnyCore/Dafny.atg Outdated Show resolved Hide resolved
docs/HowToFAQ/Errors-Parser.md Outdated Show resolved Hide resolved
docs/HowToFAQ/Errors-Parser.md Outdated Show resolved Hide resolved
docs/HowToFAQ/Errors-Parser.template Outdated Show resolved Hide resolved
robin-aws
robin-aws previously approved these changes Mar 13, 2024
@RustanLeino RustanLeino merged commit 28f3a62 into dafny-lang:master Mar 14, 2024
20 checks passed
@RustanLeino RustanLeino deleted the general-traits-message branch March 19, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants