chore: Rename adjustment to refinement #5139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// | ||
| /// So, a piece of "Advice" is saying that a given "PreType" should have a specific type *if* the program does not have any other | ||
| /// specific type for it. | ||
| /// </summary> | ||
| public abstract class Advice { |
There was a problem hiding this comment.
I think Advice could also use a more specific name, like AmbiguousTypeDefault or TypeDisambiguation
keyboardDrummer
approved these changes
Mar 4, 2024
| @@ -8,6 +8,32 @@ | |||
| using System.Collections.Generic; | |||
|
|
|||
| namespace Microsoft.Dafny { | |||
| /// <summary> | |||
| /// A piece of "Advice" is information about a default type. | |||
|
Looks great, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames "adjustment type" to the better name "refinement type". It also adds documentation to the class
Advice.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.