Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Address build warnings #5080

Merged
merged 3 commits into from
Feb 13, 2024
Merged

chore: Address build warnings #5080

merged 3 commits into from
Feb 13, 2024

Conversation

fabiomadge
Copy link
Collaborator 

Warning: /usr/share/dotnet/sdk/8.0.101/Sdks/NuGet.Build.Tasks.Pack/build/NuGet.Build.Tasks.Pack.targets(221,5): warning NU5100: The assembly 'contentFiles/any/net6.0/Microsoft.TestPlatform.PlatformAbstractions.dll' is not inside the 'lib' folder and hence it won't be added as a reference when the package is installed into a project. Move it into the 'lib' folder if it needs to be referenced. [/home/runner/work/dafny/dafny/dafny/Source/DafnyDriver/DafnyDriver.csproj]

Warning: /usr/share/dotnet/sdk/8.0.101/Sdks/NuGet.Build.Tasks.Pack/build/NuGet.Build.Tasks.Pack.targets(221,5): warning NU5119: File '/home/runner/work/dafny/dafny/dafny/Binaries/net6.0/publish/DafnyRuntimeRust/.gitignore' was not added to the package. Files and folders starting with '.' or ending with '.nupkg' are excluded by default. To include this file, use -NoDefaultExcludes from the commandline [/home/runner/work/dafny/dafny/dafny/Source/Dafny/Dafny.csproj]

keyboardDrummer
keyboardDrummer reviewed Feb 13, 2024
View reviewed changes
Source/DafnyPipeline/DafnyPipeline.csproj
@@ -122,7 +122,7 @@
<LinkBase>DafnyRuntimePython</LinkBase>
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</EmbeddedResource>
<EmbeddedResource Include="..\DafnyRuntime\DafnyRuntimeRust\**" LinkBase="DafnyRuntimeRust">
<EmbeddedResource Include="..\DafnyRuntime\DafnyRuntimeRust\**" Exclude="..\DafnyRuntime\DafnyRuntimeRust\.gitignore" LinkBase="DafnyRuntimeRust">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this for?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the second warning in the description.

@keyboardDrummer keyboardDrummer enabled auto-merge (squash) February 13, 2024 09:32
@keyboardDrummer keyboardDrummer merged commit 9dda653 into dafny-lang:master Feb 13, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keyboardDrummer keyboardDrummer keyboardDrummer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fabiomadge @keyboardDrummer