Make smaller changes to compilers #5052
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some minor changes to the compilers. These changes have been carved off from a larger set of changes (for supporting general
newtype
s andis
expressions), to simplify the reviewing of the latter.The changes in this PR are:
EmitDowncastVariableAssignment
(collectionElementType
tosourceType
).nativeType
parameter toEmitBitvectorTruncation
(to allow it to be different thanbvType.NativeType
).newtype
can have a bitvector base type, which will happen soon, and (ii) ifIntBoundedPool
starts supporting bitvector types.How has this been tested?
Since the changes are meant to preserve current behaviors (but with an eye to the up-and-coming PRs with larger changes), this PR does not make any changes to tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.