fix: Improve ghost detection in comprehensions #5041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5033
Fixes #5034
Fixes #5035
This PR allows more expressions as compiled (from issues #5033 and #5034) and also adds some missing restrictions on uses of ghosts (#5035), all having to do with set/iset/map/imap comprehensions.
How has this been tested?
The tests from these Issues have been added to
DiscoverBounds.dfyandDiscoverBoundsErrors.dfy.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.