feat: Tighten specifications on Strings standard library #4868
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As follow-up from the initial review, this adds a bodiless
CharsConsistent
lemma to the abstractStd.Strings.ParametricConversion
module that ensureschars
andcharsToDigits
are consistent, which is necessary but not sufficient to prove thatforall n :: ToInt(OfInt(n)) == n
.Also makes some documentation and naming improvements, adding an
IsDigitChar
predicate for better readability thanc in charsToDigit
(which is slightly different fromc in chars
) and merges the two confusingly-namedToNumberStr
andOfNumberStr
predicate into oneIsNumberStr
(with the definition of the former, weaker predicate).How has this been tested?
Existing tests + verification.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.