feat: Add a few more Std.Collections.Seq functions #4867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin-aws
commented
Dec 11, 2023
|
|
||
| /* Returns Some(i), if an element satisfying p occurs at least once in a sequence, and i is | ||
| the index of the first such occurrence. Otherwise the return is None. */ | ||
| function {:opaque} IndexByOption<T(==)>(xs: seq<T>, p: T -> bool): (o: Option<nat>) |
There was a problem hiding this comment.
I'd also be happy with IndexWithOption as a naming scheme.
atomb
approved these changes
Dec 11, 2023
| @@ -8,7 +8,8 @@ DOO_FILE_TARGET=binaries/DafnyStandardLibraries.doo | |||
| all: check-binary test check-format check-examples | |||
|
|
|||
| verify: | |||
| $(DAFNY) verify src/DafnyStdLibs/dfyconfig.toml | |||
There was a problem hiding this comment.
Was this just missed in the DafnyStdLibs -> Std renaming?
There was a problem hiding this comment.
Yup, forgot to call it out in the PR description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These are functions I got used to having around in THIS "standard library" and didn't spot they weren't in OUR standard library until now. :)
Also removed
Std.Strings.Concat(already covered more generically withStd.Collections.Seq.Flatten) and movedStd.Strings.JointoStd.Collections.Seq: these were only referenced by tests and their existence contradicted the documentation on the purpose of theStringslibrary.Also commented out the remaining print statements in JSONTests.dfy to keep the testing output cleaner.
How has this been tested?
DafnyStandardLibraries tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.