Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code navigation when resolution errors #4855

Merged
merged 6 commits into from
Dec 8, 2023
Merged

Code navigation when resolution errors #4855

merged 6 commits into from
Dec 8, 2023

Conversation

keyboardDrummer
Copy link
Member

@keyboardDrummer keyboardDrummer commented Dec 7, 2023 •
edited
Loading

Description

  • Allows code navigation to work even when there are resolution errors, but only if there are no resolution errors in module dependencies.

How has this been tested?

  • Added several XUnit tests

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@keyboardDrummer keyboardDrummer marked this pull request as ready for review December 7, 2023 16:18
@keyboardDrummer keyboardDrummer enabled auto-merge (squash) December 8, 2023 13:22
stefan-aws
stefan-aws approved these changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@stefan-aws stefan-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some initial (successful) tests that involved "go to definition". This is very helpful, thanks.

@keyboardDrummer keyboardDrummer merged commit 7e57091 into dafny-lang:master Dec 8, 2023
20 checks passed
@keyboardDrummer keyboardDrummer deleted the codeNavigationWhenResolutionErrors branch December 8, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefan-aws stefan-aws stefan-aws approved these changes

@MikaelMayer MikaelMayer Awaiting requested review from MikaelMayer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@keyboardDrummer @stefan-aws