fix: The Python compiler emits reserved names for datatypes #4843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin-aws
reviewed
Dec 7, 2023
docs/dev/news/4843.fix
Outdated
| @@ -0,0 +1 @@ | |||
| Python compiler emits reserved names for datatypes | |||
There was a problem hiding this comment.
Suggested change
| Python compiler emits reserved names for datatypes | |
| The Python compiler no longer emits reserved names for datatypes |
?
There was a problem hiding this comment.
My thinking is that it's a description of what needed fixing.
There was a problem hiding this comment.
Okay sure. It hasn't been our pattern, but since it ends up under a "Bug fixes" header in the release notes this style works too.
| @@ -0,0 +1,3 @@ | |||
| // RUN: %testDafnyForEachCompiler "%s" | |||
|
|
|||
| datatype None = None | |||
There was a problem hiding this comment.
How the heck did the standard libraries not trigger this?
There was a problem hiding this comment.
It's about the Dt name, not the constructor.
fabiomadge
changed the title
robin-aws
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4830