Make customBoogie.patch work with recent versions #4807
Conversation
| <PackageReference Include="System.CommandLine" Version="2.0.0-beta4.22272.1" /> | ||
| <PackageReference Include="System.Runtime.Numerics" Version="4.3.0" /> | ||
| <PackageReference Include="System.Collections.Immutable" Version="1.7.0" /> | ||
| - <PackageReference Include="Boogie.ExecutionEngine" Version="3.0.5" /> | ||
| + <ProjectReference Include="..\..\boogie\Source\ExecutionEngine\ExecutionEngine.csproj" /> | ||
| + <ProjectReference Include="..\..\boogie\Source\BaseTypes\BaseTypes.csproj" /> |
There was a problem hiding this comment.
Why do we need to reference all of these instead of just ExecutionEngine?
There was a problem hiding this comment.
I'm not 100% sure why they're necessary, but I've observed that local build fails without them but succeed with them.
There was a problem hiding this comment.
Are all of them necessary? I think we could prune this list
There was a problem hiding this comment.
I created the list by adding dependencies that the build claimed to need until it succeeded. Local builds, at least for me, don't succeed with any of them removed.
There was a problem hiding this comment.
OK, sorry. Related but not relevant for now: I'd like to change Boogie at some point so the projects that Dafny conceptually does not use at all, like Houdini or Concurrency, don't need to be included, either in the build or at runtime.
There was a problem hiding this comment.
Yeah, I'd like that, too. I agree that it's unpleasant for this change to be necessary.
The previous version of the patch would successfully apply, but would not build against a recent Boogie source tree.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.