fix: print error context snippets after their messages #4788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-chew
changed the title
atomb
approved these changes
Nov 16, 2023
| @@ -66,14 +66,14 @@ public class ConsoleErrorReporter : BatchErrorReporter { | |||
| errorLine += "\n"; | |||
| } | |||
|
|
|||
| Options.OutputWriter.Write(errorLine); | |||
|
|
|||
There was a problem hiding this comment.
The fact that this was fixed by changing the core message reporting code makes me think that some of the other messages (which already came before the snippet) aren't using this and maybe should be? Not that we need to fix that now, it's just an inconsistency we might want to resolve at some point.
There was a problem hiding this comment.
Yeah, I didn't get a chance to search for where the other messages (like normal verification failures) were bring printed from, but it's a good idea to unify them to use this logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4787.
How has this been tested?
Added
git-issue-4787.dfyto test the reported case.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.