Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not let documentSymbol API return a faulty line #4675

Merged

Conversation

keyboardDrummer
Copy link
Member

@keyboardDrummer keyboardDrummer commented Oct 17, 2023

Fixes #446

Description

Do not let documentSymbol API return a faulty line when parsing a symbol name has an error

How has this been tested?

  • Added language server test

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

MikaelMayer
MikaelMayer previously approved these changes Oct 17, 2023
Copy link
Member

@MikaelMayer MikaelMayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's sooo good thanks. I think there are a few more assumptions like that remaining in the code, but at least you are decreasing them by one !

Copy link
Collaborator

@stefan-aws stefan-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously approved modulo formatter.

@keyboardDrummer keyboardDrummer merged commit 00a700a into dafny-lang:master Oct 18, 2023
18 checks passed
robin-aws pushed a commit that referenced this pull request Oct 18, 2023
Fixes #446

### Description
Do not let documentSymbol API return a faulty line when parsing a symbol
name has an error

### How has this been tested?
- Added language server test

<small>By submitting this pull request, I confirm that my contribution
is made under the terms of the [MIT
license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error "Request textDocument/documentSymbol failed" appears regularly
3 participants